Project Hospital
Would you like to react to this message? Create an account in a few clicks or log in to continue.

Go down
avatar
Butch
attending
Posts : 45
Reputation : 7
Join date : 2019-06-06

Updating Bedside Examinations Mod  Empty Updating Bedside Examinations Mod

Sun Jul 26, 2020 1:09 am
It's been a long time since I've updated this mod but I finally got around to taking a look at it again. The mod tweaks almost every examination in the Examinations.xml file. It essentially allows many examinations to be done in the ward (obviously) but more importantly it changes the priority of every exam which results in doctors choosing exams in the same order they would in real life. I made changes to some of these exam priorities today and then tried to run the mod to test it. For some reason, the game detects that I'm running the mod but none of the changes I've made to the examinations are going through. I really want to troubleshoot but I don't know where to start. I took a look at the log file and there were no errors. So I'm going to take some wild guesses and maybe somebody can point me in the right direction.

1) I went over the modding documentation for the database once again (it's been months since I've done this) and I realized that the exam priority values listed in the documentation go from 0 - 50. In my mod, I'm using integers between 1 and 99. Does the game not recognize anything above 50? This wasn't the case in earlier versions of the game.

2) I changed the required room tags for bacteria cultivation sampling, biopsy sampling, PCR sampling and serology sampling from:

<RequiredRoomTags>
               <Tag>examinations_basic_equipment</Tag>
  </RequiredRoomTags>

to:

<RequiredRoomTags>
      <Tag>observation</Tag>
      <Tag>ward</Tag>
      <Tag>hospitalization</Tag>
      <Tag>hospitalization_high</Tag>
      <Tag>any_inpatient_office</Tag>
   </RequiredRoomTags>


I wanted those specific exams to only be allowed if the patient is hospitalized. I did this in an attempt to prevent clinic patients from going back and forth between the lab and the clinic. Did I mess this up?

3) I changed the duration of some exams. For example I changed the  duration of CT scans from:      

<DurationHours>0</DurationHours>  

to

<DurationHours>0.4</DurationHours>

Could using a decimal here have messed up everything? Does this parameter even work? I'm pretty sure every exam is instantaneous in the game and that's something I'm trying to change.


These are the only things I've changed from previous versions of the mod. I tested the mod and I'm not seeing any changes. The priorities are identical to the vanilla version of the game and doctors can still prescribe bacteria cultivation sampling, biopsy sampling, PCR sampling and serology sampling in the clinics. My mod folder is in the right place and the documentation is proper; the game detects the mod in the main menu. I would really appreciate any help.
jan.oxymoron
jan.oxymoron
developer
Posts : 2177
Reputation : 314
Join date : 2018-03-23

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Mon Jul 27, 2020 11:09 am
Hi, let me write down some tips for checking if the mod gets loaded and if there are any problems, that's probably the best place to start.

- When testing, I'd recommend to unsubscribe from the mod on the workshop (if it exists there) and only have the data under StreaminAssets\Addons - this should prevent two versions of a mod from overwriting each other
- The mod should then show up on the list in the bottom left corner of the main menu. Changing the name of the mod can be used to verify that the updated version is getting loaded.
- There will be some info in the log file about loading the database (Loading database from addon path: .../ProjectHospital_Data/StreamingAssets/Addons/ModABCDEF) and about individual database items overwriting the current ones, in your case mosty the examinations (Duplicate database entry, overriding the original one: EXM_ABCDEF)

In the next stage, when testing "incompatible mods" via workshop, this tweakable under the base game data can be changed like this to allow them to be loaded again:
<GameDBTweakableString ID="TWEAKABLE_INCOMPATIBLE_WORKSHOP_MODS">             <Value>none</Value>   </GameDBTweakableString>

Now, regarding the three points:
1) and 2) these should work, basically this is why it makes sense to check everything is getting loaded correctly Smile
3) the duration is only used for laboratory tests, radiology exams mostly take the same time every time, with a slight variation of duration of one of the steps according to the radiologist's level

I hope these help, let us know if you found what the issue was!
Also, when the mod is ready, we should be able to quickly re-enable it in game in the next patch/hotfix.
avatar
Butch
attending
Posts : 45
Reputation : 7
Join date : 2019-06-06

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 3:43 am
No luck. I wasn't subscribed to any mods while testing. I tried changing the name of the mod just to see if the game would detect the updated version of the game. It did, so clearly its detecting the changes . I checked the log and it does indeed state that there are duplicate database entries - as expected. The game is just ignoring the priority values for the exams that I've edited. It also ignores the changed required room tags for some of the exams that I've also changed. What could I be missing?
jan.oxymoron
jan.oxymoron
developer
Posts : 2177
Reputation : 314
Join date : 2018-03-23

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 1:37 pm
Hi, thanks for the update - the priorities should affect the order of examinations shown in patient's card (first place to verify they are applied), double-checking the code that handles this, it simply compares the priorities, nothing fancy. There's one hard-coded exception, Observation has priority of 30, so anything that should be performed before sending patients to observation should have a higher priority.

If everything seems to be in order in the xmls on your side, feel free to send us/attach the ModExaminations.xnl file, I can have a quick look too (quite curious what the issue actually is).
avatar
Butch
attending
Posts : 45
Reputation : 7
Join date : 2019-06-06

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 2:24 pm
It's very odd, I really don't know where I messed up, everything does seem in order. I've shared the file on Discord with some fellow modders and they couldn't figure it out either. I can't attach XML files to this message so I uploaded to a file sharing platform.

Here's the link:
https://gofile.io/d/hqpM30

Alternatively, I've attached a .txt version as well.
Attachments
Updating Bedside Examinations Mod  Attachment
bedside examinations txt.txt You don't have permission to download attachments.(146 Kb) Downloaded 4 times
avatar
Butch
attending
Posts : 45
Reputation : 7
Join date : 2019-06-06

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 2:30 pm
Here's a copy of my log as well.
Attachments
Updating Bedside Examinations Mod  Attachment
output_log.txt You don't have permission to download attachments.(30 Kb) Downloaded 5 times
avatar
juraj.horvath
specialist
Posts : 146
Reputation : 8
Join date : 2018-08-07
Age : 41
Location : Bratislava, Slovak Republic

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 3:22 pm
Hi,

you have an error on line 634, examination EXM_CBC_SAMPLING, you have XML node without same start XML node
Code:
</RequiredRoomTypeList>

PS. to DEVS: Exception occurred while processing mod XML files are not logged to output_log.txt.


Last edited by juraj.horvath on Tue Jul 28, 2020 3:26 pm; edited 1 time in total (Reason for editing : exception notice)

Butch likes this post

jan.oxymoron
jan.oxymoron
developer
Posts : 2177
Reputation : 314
Join date : 2018-03-23

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 4:49 pm
Hi, ok, hopefully this was it!

@juraj - Thanks for finding out, I also double checked the error reporting and these exception were indeed shown only in game (more specifically: options in main menu, as these were usually related to errors in the localization XMLs), I'm adding the error to the log for the next patch
@Butch - A quick question: which editor are you using for editing the xmls? Some more advanced ones should actually highlight similar issues directly, maybe Notepad++ does that?
avatar
Butch
attending
Posts : 45
Reputation : 7
Join date : 2019-06-06

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 5:29 pm
@Juraj - You found it cheers Which program are you using to read your XMLs?

@Jan - I actually use Notepad ++ but sadly there was no prompt notifying me about the XML start node issue.

I really can't wait to finally push the updated version to the workshop. That little piece of information you gave me about the EXM_Observation being hardcoded at 30 priority changes EVERYTHING. I've always wanted to be able to send ER patients to the observation before doing certain exams. People are going to really appreciate the next update to the mod. Thank you so much both of you!
avatar
juraj.horvath
specialist
Posts : 146
Reputation : 8
Join date : 2018-08-07
Age : 41
Location : Bratislava, Slovak Republic

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Tue Jul 28, 2020 5:46 pm
Butch wrote:@Juraj - You found it cheers Which program are you using to read your XMLs?
Notepad ++
avatar
Butch
attending
Posts : 45
Reputation : 7
Join date : 2019-06-06

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Wed Jul 29, 2020 3:30 am
So I tested my Bedside Examinations mod and it works exactly how I want it to. I uploaded the mod to the workshop and then subscribed to it after removing it from the StreamingAssets > Addons folder. However now it says the mod is incompatible with the current version of the game and that it hasn't loaded. I understand that Realistic Collapses is flagged as incompatible but Bedside Examinations is not. Why is the mod showing up in red and imcompatible in the main menu?
jan.oxymoron
jan.oxymoron
developer
Posts : 2177
Reputation : 314
Join date : 2018-03-23

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Wed Jul 29, 2020 11:31 am
Message reputation : 100% (1 vote)
Butch wrote:So I tested my Bedside Examinations mod and it works exactly how I want it to. I uploaded the mod to the workshop and then subscribed to it after removing it from the StreamingAssets > Addons folder. However now it says the mod is incompatible with the current version of the game and that it hasn't loaded. I understand that Realistic Collapses is flagged as incompatible but Bedside Examinations is not. Why is the mod showing up in red and imcompatible in the main menu?

Hi, ok, that's great news!

We'll remove the mod from the list of incompatible ones on the game side (and re-enable it on the workshop) in the next patch/hotfix, possibly already this week (we have a couple small fixes that we can release with it).

Just as a quick explanation as you're probably not aware of this - marking a mod incompatible on Steam unfortunately doesn't have any effect on players that already have it installed, so we implemented our own system on game side in patch 29 (there's more info in the release notes: https://store.steampowered.com/newshub/app/868360/view/2712806889516080035)

If you'd like to test the workshop version in the meantime, you can change the following tweakable like this: <GameDBTweakableString ID="TWEAKABLE_INCOMPATIBLE_WORKSHOP_MODS"> <Value>none</Value> </GameDBTweakableString>

I can post a reply here when the next version is live - and we'll probably give the mod a shoutout in the release notes. Smile

Butch likes this post

avatar
Butch
attending
Posts : 45
Reputation : 7
Join date : 2019-06-06

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Wed Jul 29, 2020 1:21 pm
Hi, ok, that's great news!

We'll remove the mod from the list of incompatible ones on the game side (and re-enable it on the workshop) in the next patch/hotfix, possibly already this week (we have a couple small fixes that we can release with it).

Just as a quick explanation as you're probably not aware of this - marking a mod incompatible on Steam unfortunately doesn't have any effect on players that already have it installed, so we implemented our own system on game side in patch 29 (there's more info in the release notes: https://store.steampowered.com/newshub/app/868360/view/2712806889516080035)

If you'd like to test the workshop version in the meantime, you can change the following tweakable like this: <GameDBTweakableString ID="TWEAKABLE_INCOMPATIBLE_WORKSHOP_MODS"> <Value>none</Value> </GameDBTweakableString>

I can post a reply here when the next version is live - and we'll probably give the mod a shoutout in the release notes. Smile


Thank you Jan, you've been extremely helpful. I might as well update Realistic Collapses before then so that you can enable both mods at the same time. There are a few questions I'd like to ask about certain tweakables so I'll just start a new thread for that mod.
jan.oxymoron
jan.oxymoron
developer
Posts : 2177
Reputation : 314
Join date : 2018-03-23

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Wed Jul 29, 2020 2:06 pm
Butch wrote:
Thank you Jan, you've been extremely helpful. I might as well update Realistic Collapses before then so that you can enable both mods at the same time. There are a few questions I'd like to ask about certain tweakables so I'll just start a new thread for that mod.

Hi, sure, this is completely up to you, just let us know when everything is ready - and I'll try to answer any questions in the meantime. Smile

(Note: I think the link from my previous reply doesn't work, trying again: https://store.steampowered.com/newshub/app/868360/view/2712806889516080035 )
Sponsored content

Updating Bedside Examinations Mod  Empty Re: Updating Bedside Examinations Mod

Back to top
Permissions in this forum:
You cannot reply to topics in this forum